[HUDI-8882] Support Compaction/Rollback/Clean Timeline Instant Metrics in HoodieMetrics #12681
+140
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -565,7 +565,7 @@ protected void postCommit(HoodieTable table, HoodieCommitMetadata metadata, Stri | |||
| // Delete the marker directory for the instant. | |||
| WriteMarkersFactory.get(config.getMarkersType(), table, instantTime) | |||
| .quietDeleteMarkerDir(context, config.getMarkersDeleteParallelism()); | |||
| metrics.updateClusteringTimeLineInstantMetrics(table.getActiveTimeline()); | |||
| metrics.updateTimelineInstantMetrics(table.getActiveTimeline()); | |||
There was a problem hiding this comment.
could we rename this function to updateTableServiceInstantMetrics
| } | ||
| } | ||
|
|
||
| private void updatePendingInstantCount(final HoodieActiveTimeline activeTimeline, |
There was a problem hiding this comment.
could we add some java docs? what does PendingInstantCount mean? and what is this metric used for?
Comment on lines
+431
to
+438
| if (HoodieTableType.MERGE_ON_READ.name().equalsIgnoreCase(tableType) | ||
| && LATEST_COMPLETED_COMPACTION_INSTANT_STR.equalsIgnoreCase(metricName)) { | ||
| action = HoodieActiveTimeline.COMMIT_ACTION; | ||
| } | ||
| if (HoodieTableType.COPY_ON_WRITE.name().equalsIgnoreCase(tableType) | ||
| && LATEST_COMPLETED_CLUSTERING_INSTANT_STR.equalsIgnoreCase(metricName)) { | ||
| action = HoodieActiveTimeline.REPLACE_COMMIT_ACTION; | ||
| } |
There was a problem hiding this comment.
Could we use switch style?
Also no need to take care of tableType, bcz MOR table also can do clustering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Similar like #12466 , this PR add time instant metrics for compaction、clean、rollback：
earliest_inflight_XXX_instant
latest_completed_XXX_instant
clustering_pendingXXXCount
Also, this PR refine the whole code impl.
Impact
hudi-client-common
Risk level (write none, low medium or high below)
Low
Documentation Update
None
Contributor's checklist