getSerializableNodeInstances_fix

apache · Oct 22, 2024 · c50c898 · c50c898
1 parent ac28d72
commit c50c898
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/jbpm/jbpm-flow/src/main/java/org/jbpm/workflow/instance/node/ForEachNodeInstance.java b/jbpm/jbpm-flow/src/main/java/org/jbpm/workflow/instance/node/ForEachNodeInstance.java
@@ -354,7 +354,6 @@ public int getLevelForNode(String uniqueID) {
         return 1;
     }
 
-    @Override
     public Collection<org.kie.api.runtime.process.NodeInstance> getSerializableNodeInstances() {
         return getNodeInstances().stream().filter(ForEachNodeInstance::isSerializable).collect(Collectors.toUnmodifiableList());
     }

diff --git a/...rotobuf/src/main/java/org/jbpm/flow/serialization/impl/ProtobufProcessInstanceWriter.java b/...rotobuf/src/main/java/org/jbpm/flow/serialization/impl/ProtobufProcessInstanceWriter.java
@@ -249,7 +249,7 @@ public FieldDescriptor getContextField(GeneratedMessageV3.Builder<?> builder) {
     }
 
     protected <T extends NodeInstanceContainer & ContextInstanceContainer & ContextableInstance> WorkflowContext buildWorkflowContext(T nodeInstance) {
-        List<NodeInstance> nodeInstances = new ArrayList<>(nodeInstance.getSerializableNodeInstances());
+        List<NodeInstance> nodeInstances = new ArrayList<>(nodeInstance.getNodeInstances());
         List<ContextInstance> exclusiveGroupInstances = nodeInstance.getContextInstances(ExclusiveGroup.EXCLUSIVE_GROUP);
         VariableScopeInstance variableScopeInstance = (VariableScopeInstance) nodeInstance.getContextInstance(VariableScope.VARIABLE_SCOPE);
         List<Map.Entry<String, Object>> variables = (variableScopeInstance != null) ? new ArrayList<>(variableScopeInstance.getVariables().entrySet()) : Collections.emptyList();

diff --git a/...buf/src/test/java/org/jbpm/flow/serialization/impl/ProtobufProcessInstanceWriterTest.java b/...buf/src/test/java/org/jbpm/flow/serialization/impl/ProtobufProcessInstanceWriterTest.java
@@ -89,7 +89,7 @@ void buildWorkflowContext() {
             ArgumentCaptor<List<Map.Entry<String, Integer>>> iterationlevelsCapture = ArgumentCaptor.forClass(ArrayList.class);
             verify(spiedProtobufProcessInstanceWriter).buildWorkflowContext(nodeInstancesCapture.capture(), exclusiveGroupInstancesCapture.capture(), variablesCapture.capture(),
                     iterationlevelsCapture.capture());
-            Collection<NodeInstance> expected = nodeInstance.getSerializableNodeInstances();
+            Collection<NodeInstance> expected = nodeInstance.getNodeInstances();
             List<NodeInstance> retrieved = nodeInstancesCapture.getValue();
             assertThat(retrieved).isNotNull().hasSize(expected.size()).allMatch(expected::contains);
         }