Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override assertj version in codestart integration-test pom #2100

Closed
wants to merge 2 commits into from
Closed

Override assertj version in codestart integration-test pom #2100

wants to merge 2 commits into from

Conversation

ia3andy
Copy link

@ia3andy ia3andy commented Mar 23, 2022

A cleaner fix for the issue described in https://github.com/kiegroup/kogito-runtimes/pull/2093

Temporary override version from kogito-dependencies-bom to make sure it is api compatible with quarkus-devtools-testing

This reverts commit 13155de (from https://github.com/kiegroup/kogito-runtimes/pull/2093)

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

27 similar comments
@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

22 similar comments
@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@kie-ci
Copy link
Contributor

kie-ci commented Mar 23, 2022

Can one of the admins verify this patch?

@evacchi
Copy link
Contributor

evacchi commented Mar 23, 2022

ok to test

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kie-ci1
Copy link

kie-ci1 commented Mar 23, 2022

(tests) - kogito-runtimes job #1293 was: UNSTABLE
Possible explanation: This should be test failures

Test results:

  • PASSED: 2573
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.dmn.KogitoDMNCodeCodestartIT.testContent java.lang.NoSuchMethodError: 'org.assertj.core.api.AbstractAssert org.assertj.core.api.AbstractPathAssert.satisfies(java.util.function.Consumer)'
at org.kie.kogito.quarkus.dmn.KogitoDMNCodeCodestartIT.testContent(KogitoDMNCodeCodestartIT.java:53)

Please look here: https://eng-jenkins-csb-business-automation.apps.ocp-c1.prod.psi.redhat.com/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-runtimes.tests.kogito-runtimes/1293/display/redirect

@ia3andy
Copy link
Author

ia3andy commented Mar 24, 2022

This is on hold until we figure out why the version is not propagated at runtime.

@evacchi evacchi mentioned this pull request Mar 24, 2022
Merged
@baldimir
Copy link
Contributor

baldimir commented Oct 4, 2023

Hi @ia3andy, is this still relevant please? If yes, could you please rebase with the latest changes from main?

@ia3andy ia3andy closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ia3andy @kie-ci @evacchi @kie-ci1 @baldimir