Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#647: add writeJunitReport to invoker configuration #3258

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

jstastny-cz
Copy link
Contributor

apache/incubator-kie-issues#647

Given that CI builds set maven.test.failure.ignore to true, any build failure would be silently ignored, unless invoker plugin writes the build fail as a junit report with failure outcome.

This is achieved by property writeJunitReport which is false by default and needs to be overriden.

To be validated by presence of test case maven.invoker.it.integration-tests-springboot-kafka-it.integration-tests-springboot-kafka-it in the test results.

@elguardian
Copy link
Contributor

LGTM. just to double check. This will allow to continue with the test in other modules or will cause to stop continuing ? @jstastny-cz

@jstastny-cz
Copy link
Contributor Author

@elguardian this will only write down the failure as a failed test case so that it's picked up by junit test results publishers.

So the builds will run the same way as they used to so far.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 24, 2023

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3258 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3258/2/display/redirect

Test results:

  • PASSED: 3384
  • FAILED: 1

Those are the test failures:

org.kie.kogito.addon.quarkus.messaging.common.QuarkusEventThreadPoolTest.testQuarkusEventThreadPoolMultiThreadLongQueueTest expected: not equal but was: <0>

Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jstastny-cz
Copy link
Contributor Author

Given the nature of this fix, I am gonna merge with the one failing test:

  • previously, for the first commit there was a green build
  • the maven.invoker.it test results are in the jenkins job report correctly

@jstastny-cz jstastny-cz merged commit 6e00b1e into apache:main Oct 25, 2023
4 of 5 checks passed
@jstastny-cz jstastny-cz deleted the kie-issues#647 branch October 25, 2023 09:05
rgdoliveira pushed a commit to kiegroup/kogito-runtimes that referenced this pull request Dec 13, 2023
…#3258)

* kie-issues#647: add writeJunitReport to invoker configuration

* Fix whitespace error

---------

Co-authored-by: jstastny-cz <jan.stastny@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants