-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#647: add writeJunitReport to invoker configuration #3258
Conversation
LGTM. just to double check. This will allow to continue with the test in other modules or will cause to stop continuing ? @jstastny-cz |
@elguardian this will only write down the failure as a failed test case so that it's picked up by junit test results publishers. So the builds will run the same way as they used to so far. |
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3258 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3258/2/display/redirect Test results:
Those are the test failures: org.kie.kogito.addon.quarkus.messaging.common.QuarkusEventThreadPoolTest.testQuarkusEventThreadPoolMultiThreadLongQueueTestexpected: not equal but was: <0> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Given the nature of this fix, I am gonna merge with the one failing test:
|
…#3258) * kie-issues#647: add writeJunitReport to invoker configuration * Fix whitespace error --------- Co-authored-by: jstastny-cz <jan.stastny@ibm.com>
apache/incubator-kie-issues#647
Given that CI builds set
maven.test.failure.ignore
to true, any build failure would be silently ignored, unless invoker plugin writes the build fail as a junit report with failure outcome.This is achieved by property writeJunitReport which is false by default and needs to be overriden.
To be validated by presence of test case
maven.invoker.it.integration-tests-springboot-kafka-it.integration-tests-springboot-kafka-it
in the test results.