Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly trace cloud events #3271

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Oct 31, 2023

Pretty print was being called and concatenated regardless the logger is enable or not. Due to the massive amount of events that we might potentially received there, this might well explain why some test were timing out. In any case, it is a mistake that should be fixed.

Update:
Since the failure was still there, I tried invoking the operation after event registration, to rule out process publishing event too soon

Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 31, 2023

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3271 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3271/1/display/redirect

Test results:

  • PASSED: 3257
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojo
Expecting value to be true but was false

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 31, 2023

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3271 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3271/2/display/redirect

Test results:

  • PASSED: 3106
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.PojoServiceIT.testFilterPojo
Expected size: 1 but was: 2 in:
{"age"=666, "name"="javieritoPerson"}

Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elguardian
Copy link
Contributor

@fjtirado this belongs to unstable test due to kafka streams no reset among tests. you can merge this if you want.

@fjtirado fjtirado merged commit da0919b into apache:main Nov 6, 2023
5 checks passed
rgdoliveira pushed a commit to kiegroup/kogito-runtimes that referenced this pull request Dec 13, 2023
* Properly trace cloud events

* Trying to avoid flaky test on PojoServiceIt

* Revert "Trying to avoid flaky test on PojoServiceIt"

This reverts commit 8a6a38a.

* Try setting test order

* Revert "Try setting test order"

This reverts commit 57e6a5b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants