-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly trace cloud events #3271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3271 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3271/1/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.PojoServiceIT.testPojoExpecting value to be true but was false |
This reverts commit 8a6a38a.
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3271 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3271/2/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.workflows.PojoServiceIT.testFilterPojoExpected size: 1 but was: 2 in: {"age"=666, "name"="javieritoPerson"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fjtirado this belongs to unstable test due to kafka streams no reset among tests. you can merge this if you want. |
This reverts commit 57e6a5b.
Pretty print was being called and concatenated regardless the logger is enable or not. Due to the massive amount of events that we might potentially received there, this might well explain why some test were timing out. In any case, it is a mistake that should be fixed.
Update:
Since the failure was still there, I tried invoking the operation after event registration, to rule out process publishing event too soon