Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing flaky test failing in multiple PRs #3747

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Oct 22, 2024

This is appearing consistently in multiple PRs after merging issue 1522

Executing work item WorkItem 5ee6fb6f-a098-44db-b345-645d9ceb3671 [name=Human Task, state=1, processInstanceId=4239d505-5136-431a-85bb-e69ee7f4d2c7, parameters{UNIQUE_TASK_ID=_5, NodeName=Two}]
2024-10-22T15:29:09.0028304Z [ERROR] Tests run: 49, Failures: 1, Errors: 0, Skipped: 5, Time elapsed: 5.791 s <<< FAILURE! -- in org.jbpm.bpmn2.StandaloneBPMNProcessTest
2024-10-22T15:29:09.0033454Z [ERROR] org.jbpm.bpmn2.StandaloneBPMNProcessTest.testEventBasedSplit2 -- Time elapsed: 0.532 s <<< FAILURE!
2024-10-22T15:29:09.0034881Z org.opentest4j.AssertionFailedError:
2024-10-22T15:29:09.0035522Z
2024-10-22T15:29:09.0035868Z expected: 2
2024-10-22T15:29:09.0036528Z but was: 1
2024-10-22T15:29:09.0037477Z at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
2024-10-22T15:29:09.0039157Z at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
2024-10-22T15:29:09.0041121Z at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
2024-10-22T15:29:09.0043171Z at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
2024-10-22T15:29:09.0044694Z at org.jbpm.bpmn2.StandaloneBPMNProcessTest.testEventBasedSplit2(StandaloneBPMNProcessTest.java:405)
2024-10-22T15:29:09.0046062Z at java.base/java.lang.reflect.Method.invoke(Method.java:569)
2024-10-22T15:29:09.0047045Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2024-10-22T15:29:09.0048211Z at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

Copy link
Contributor

@gitgabrio gitgabrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fjtirado LGTM!

@fjtirado fjtirado merged commit 3731a74 into apache:main Oct 23, 2024
4 of 6 checks passed
@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 23, 2024

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3747 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3747/2/display/redirect

Test results:

  • PASSED: 3395
  • FAILED: 1

Those are the test failures:

org.jbpm.bpmn2.IntermediateEventTest.testIntermediateCatchEventTimerCycle3
expected: 3
but was: 2

rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants