[#2349] Improvement: Fix the warning: unchecked method invocation: me…

…thod put in interface Map is applied to given types
apache · Jan 24, 2025 · 0a73414 · 0a73414
1 parent 08e7397
commit 0a73414
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/client/src/main/java/org/apache/uniffle/client/record/reader/RMRecordsReader.java b/client/src/main/java/org/apache/uniffle/client/record/reader/RMRecordsReader.java
@@ -194,9 +194,9 @@ public int compare(K o1, K o2) {
 
   public void start() {
     for (int partitionId : partitionIds) {
-      mergeBuffers.put(partitionId, new Queue(maxBufferPerPartition));
+      mergeBuffers.put(partitionId, new Queue<>(maxBufferPerPartition));
       if (this.combiner != null) {
-        combineBuffers.put(partitionId, new Queue(maxBufferPerPartition));
+        combineBuffers.put(partitionId, new Queue<>(maxBufferPerPartition));
       }
       RecordsFetcher fetcher = new RecordsFetcher(partitionId);
       fetcher.start();

diff --git a/...est/common/src/test/java/org/apache/uniffle/test/RemoteMergeShuffleWithRssClientTest.java b/...est/common/src/test/java/org/apache/uniffle/test/RemoteMergeShuffleWithRssClientTest.java
@@ -641,7 +641,7 @@ public void remoteMergeWriteReadTestMultiPartition(String classes) throws Except
     Map<Integer, Set<Long>> ptb = new HashMap<>();
     for (int i = PARTITION_ID; i < PARTITION_ID + 3; i++) {
       final int partitionId = i;
-      ptb.put(partitionId, new HashSet());
+      ptb.put(partitionId, new HashSet<>());
       ptb.get(partitionId)
           .addAll(
               blocks1.stream()
@@ -854,7 +854,7 @@ public void remoteMergeWriteReadTestMultiPartitionWithCombine(String classes) th
     Map<Integer, Set<Long>> ptb = new HashMap<>();
     for (int i = PARTITION_ID; i < PARTITION_ID + 3; i++) {
       final int partitionId = i;
-      ptb.put(partitionId, new HashSet());
+      ptb.put(partitionId, new HashSet<>());
       ptb.get(partitionId)
           .addAll(
               blocks1.stream()

diff --git a/...t/java/org/apache/uniffle/test/RemoteMergeShuffleWithRssClientTestWhenShuffleFlushed.java b/...t/java/org/apache/uniffle/test/RemoteMergeShuffleWithRssClientTestWhenShuffleFlushed.java
@@ -655,7 +655,7 @@ public void remoteMergeWriteReadTestMultiPartition(String classes) throws Except
     Map<Integer, Set<Long>> ptb = new HashMap<>();
     for (int i = PARTITION_ID; i < PARTITION_ID + 3; i++) {
       final int partitionId = i;
-      ptb.put(partitionId, new HashSet());
+      ptb.put(partitionId, new HashSet<>());
       ptb.get(partitionId)
           .addAll(
               blocks1.stream()
@@ -869,7 +869,7 @@ public void remoteMergeWriteReadTestMultiPartitionWithCombine(String classes) th
     Map<Integer, Set<Long>> ptb = new HashMap<>();
     for (int i = PARTITION_ID; i < PARTITION_ID + 3; i++) {
       final int partitionId = i;
-      ptb.put(partitionId, new HashSet());
+      ptb.put(partitionId, new HashSet<>());
       ptb.get(partitionId)
           .addAll(
               blocks1.stream()