MINOR: reload4j build dependency fixes #12144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upgrade-system-tests` Versions 0100 and 0101 had a transitive dependency to log4j and slf4j-log4j12 via zkclient and zookeeper.
ijuma
changed the title
ijuma
added a commit
that referenced
this pull request
May 11, 2022
* Replace `log4j` with `reload4j` in `copyDependantLibs`. Since we have some projects that have an explicit `reload4j` dependency, it was included in the final release release tar - i.e. it was effectively a workaround for this bug. * Exclude `log4j` and `slf4j-log4j12` transitive dependencies for `streams:upgrade-system-tests`. Versions 0100 and 0101 had a transitive dependency to `log4j` and `slf4j-log4j12` via `zkclient` and `zookeeper`. This avoids classpath conflicts that lead to [NoSuchFieldError](qos-ch/reload4j#41) in system tests. Reviewers: Jason Gustafson <jason@confluent.io>
ijuma
added a commit
that referenced
this pull request
May 11, 2022
* Replace `log4j` with `reload4j` in `copyDependantLibs`. Since we have some projects that have an explicit `reload4j` dependency, it was included in the final release release tar - i.e. it was effectively a workaround for this bug. * Exclude `log4j` and `slf4j-log4j12` transitive dependencies for `streams:upgrade-system-tests`. Versions 0100 and 0101 had a transitive dependency to `log4j` and `slf4j-log4j12` via `zkclient` and `zookeeper`. This avoids classpath conflicts that lead to [NoSuchFieldError](qos-ch/reload4j#41) in system tests. Reviewers: Jason Gustafson <jason@confluent.io>
|
Merged to trunk and cherry-picked to 3.2 and 3.1 branches. |
jeffkbkim
added a commit
to confluentinc/kafka
that referenced
this pull request
May 12, 2022
…cs-11-may-2022 * apache-kafka/3.1: (51 commits) MINOR: reload4j build dependency fixes (apache#12144) KAFKA-13255: Use config.properties.exclude when mirroring topics (apache#11401) KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionsManager (round 3) (apache#12096) KAFKA-13794: Follow up to fix producer batch comparator (apache#12006) fix: make sliding window works without grace period (#kafka-13739) (apache#11980) 3.1.1 release notes (apache#12001) KAFKA-13794; Fix comparator of `inflightBatchesBySequence` in `TransactionManager` (apache#11991) KAFKA-13782; Ensure correct partition added to txn after abort on full batch (apache#11995) KAFKA-13748: Do not include file stream connectors in Connect's CLASSPATH and plugin.path by default (apache#11908) KAFKA-13775: CVE-2020-36518 - Upgrade jackson-databind to 2.12.6.1 (apache#11962) ...
jeffkbkim
added a commit
to confluentinc/kafka
that referenced
this pull request
May 12, 2022
This reverts commit bafa69e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log4jwithreload4jincopyDependantLibs. Since we havesome projects that have an explicit
reload4jdependency, itwas included in the final release release tar - i.e. it was effectively
a workaround for this bug.
log4jandslf4j-log4j12transitive dependencies forstreams:upgrade-system-tests. Versions 0100 and 0101had a transitive dependency to
log4jandslf4j-log4j12viazkclientandzookeeper. This avoids classpath conflicts that leadto NoSuchFieldError in
system tests.
Committer Checklist (excluded from commit message)