Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[KYUUBI #6865] [TEST] Set kyuubi.zookeeper.embedded.client.port.address to localhost for testing" #6871

Closed
wants to merge 1 commit into from

Conversation

turboFei
Copy link
Member

This reverts commit e8cbff3.

Why are the changes needed?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

…ient.port.address` to `localhost` for testing"

This reverts commit e8cbff3.
@turboFei
Copy link
Member Author

because #6870 (comment)

@turboFei turboFei added this to the v1.11.0 milestone Dec 26, 2024
@turboFei turboFei self-assigned this Dec 26, 2024
@turboFei turboFei closed this in 8742334 Dec 26, 2024
@turboFei turboFei deleted the revert_zk branch December 26, 2024 18:08
@turboFei
Copy link
Member Author

It is only for testing, just revert it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (e8cbff3) to head (1c61f9d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6871   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         688     688           
  Lines       42545   42545           
  Branches     5800    5800           
======================================
  Misses      42545   42545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants