[KYUUBI #6866][FOLLOWUP] Prevent register gauge conflicts if both thrift binary SSL and thrift http SSL enabled #6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
turboFei
force-pushed
the
duplicate_gauge
branch
from
f43ecca to
fe48b66
Compare
turboFei
force-pushed
the
duplicate_gauge
branch
from
fe48b66 to
ea35676
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6872 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 688 688
Lines 42545 42547 +2
Branches 5800 5801 +1
======================================
- Misses 42545 42547 +2 ☔ View full report in Codecov by Sentry. |
pan3793
approved these changes
Dec 27, 2024
|
#6866 goes 1.10.2 too, but this goes olny 1.11.0? |
|
Thanks, merged to main and 1.10.2 |
turboFei
added a commit
that referenced
this pull request
Dec 27, 2024
…ift binary SSL and thrift http SSL enabled ### Why are the changes needed? Followup for #6866 It would throw exception if both thrift binary SSL and thrift http SSL enabled ### How was this patch tested? ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6872 from turboFei/duplicate_gauge. Closes #6866 ea35676 [Wang, Fei] prevent conflicts 982f175 [Wang, Fei] conflicts Authored-by: Wang, Fei <fwang12@ebay.com> Signed-off-by: Wang, Fei <fwang12@ebay.com> (cherry picked from commit 164df8d) Signed-off-by: Wang, Fei <fwang12@ebay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Followup for #6866
It would throw exception if both thrift binary SSL and thrift http SSL enabled
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.