Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqlalchemy_presto.py add try_cast #6899

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pinohans
Copy link

@pinohans pinohans commented Jan 21, 2025

Update sqlalchemy_presto.py add try_cast

Why are the changes needed?

New API.
When users encounter dirty data when using CAST, TRY_CAST becomes more useful.

How was this patch tested?

Local test with sqlalchemy.

Was this patch authored or co-authored using generative AI tooling?

No

Update sqlalchemy_presto.py add try_cast
Copy link
Member

@pan3793 pan3793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes without reasonable "Why" won't be considered.

Update test_sqlalchemy_presto.py add unittest
Update test_sqlalchemy_presto.py add unittest
@pinohans pinohans requested a review from pan3793 January 23, 2025 02:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (b0f3c00) to head (780ce61).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #6899   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         688     688           
  Lines       42590   42590           
  Branches     5805    5805           
======================================
  Misses      42590   42590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants