Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewed All codec tests. No real issues found. Did some cleanup. #425

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Reviewed All codec tests. No real issues found. Did some cleanup. #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a495db
Reviewd All codecs. No real issues found. Added comments and removed…
rclabo Feb 18, 2021
afc5a70
Removed obsolete comment, and [Test] override methods no longer needed.
rclabo Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Lucene.Net.Tests.Codecs/IntBlock/TestVariableIntBlockPostingsFormat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ namespace Lucene.Net.Codecs.IntBlock
* limitations under the License.
*/

//using MockVariableIntBlockPostingsFormat = org.apache.lucene.codecs.mockintblock.MockVariableIntBlockPostingsFormat;
//using BasePostingsFormatTestCase = org.apache.lucene.index.BasePostingsFormatTestCase;
//using TestUtil = org.apache.lucene.util.TestUtil;
//using TestUtil = org.apache.lucene.util.TestUtil;

/// <summary>
/// Basic tests for VariableIntBlock
Expand Down
62 changes: 0 additions & 62 deletions src/Lucene.Net.Tests.Codecs/Memory/TestFSTOrdPostingsFormat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,67 +33,5 @@ protected override Codec GetCodec()
return codec;
}


#region BasePostingsFormatTestCase
// LUCENENET NOTE: Tests in an abstract base class are not pulled into the correct
// context in Visual Studio. This fixes that with the minimum amount of code necessary
// to run them in the correct context without duplicating all of the tests.

[Test]
public override void TestDocsOnly()
{
base.TestDocsOnly();
}

[Test]
public override void TestDocsAndFreqs()
{
base.TestDocsAndFreqs();
}

[Test]
public override void TestDocsAndFreqsAndPositions()
{
base.TestDocsAndFreqsAndPositions();
}

[Test]
public override void TestDocsAndFreqsAndPositionsAndPayloads()
{
base.TestDocsAndFreqsAndPositionsAndPayloads();
}

[Test]
public override void TestDocsAndFreqsAndPositionsAndOffsets()
{
base.TestDocsAndFreqsAndPositionsAndOffsets();
}

[Test]
public override void TestDocsAndFreqsAndPositionsAndOffsetsAndPayloads()
{
base.TestDocsAndFreqsAndPositionsAndOffsetsAndPayloads();
}

[Test]
public override void TestRandom()
{
base.TestRandom();
}

#endregion

#region BaseIndexFileFormatTestCase
// LUCENENET NOTE: Tests in an abstract base class are not pulled into the correct
// context in Visual Studio. This fixes that with the minimum amount of code necessary
// to run them in the correct context without duplicating all of the tests.

[Test]
public override void TestMergeStability()
{
base.TestMergeStability();
}

#endregion
}
}
2 changes: 1 addition & 1 deletion src/Lucene.Net.Tests.Codecs/Pulsing/Test10KPulsings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public virtual void Test10kPulsed()
Field field = NewField("field", "", ft);
document.Add(field);

//NumberFormat df = new DecimalFormat("00000", new DecimalFormatSymbols(Locale.ROOT));
//NumberFormat df = new DecimalFormat("00000", new DecimalFormatSymbols(Locale.ROOT)); // LUCENENET specific: Use .ToString formating instead

for (int i = 0; i < 10050; i++)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Lucene.Net.Tests.Codecs/SimpleText/TestSimpleTextPostingsFormat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace Lucene.Net.Codecs.SimpleText
/// Tests SimpleText's postings
/// </summary>
[Nightly] // please figure out why I am so horrendously slow!
public class TestSimpleTextPostingsFormat : BasePostingsFormatTestCase // please figure out why I am so horrendously slow!
public class TestSimpleTextPostingsFormat : BasePostingsFormatTestCase
{
private readonly Codec codec = new SimpleTextCodec();

Expand Down
1 change: 1 addition & 0 deletions src/Lucene.Net.Tests.Codecs/SimpleText/TestSimpleTextStoredFieldsFormat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ protected override Codec GetCodec()
return new SimpleTextCodec();
}


NightOwl888 marked this conversation as resolved.
Show resolved Hide resolved
[Deadlock][Timeout(600000)]
public override void TestConcurrentReads()
{
Expand Down