Skip to content

Commit

Permalink
Maven DaemonCLI for 3 and 4 were not aligned (#915)
Browse files Browse the repository at this point in the history
As comments are supported for both 3 and 4 but mvnd did not
support them in 3.
  • Loading branch information
cstamas authored Mar 29, 2024
1 parent 90b505a commit d5d697c
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,8 @@ void cli(CliRequest cliRequest) throws Exception {

if (configFile.isFile()) {
try (Stream<String> lines = Files.lines(configFile.toPath(), Charset.defaultCharset())) {
String[] args = lines.filter(arg -> !arg.isEmpty()).toArray(String[]::new);
String[] args = lines.filter(arg -> !arg.isEmpty() && !arg.startsWith("#"))
.toArray(String[]::new);
mavenConfig = cliManager.parse(args);
List<?> unrecognized = mavenConfig.getArgList();
if (!unrecognized.isEmpty()) {
Expand Down

0 comments on commit d5d697c

Please sign in to comment.