-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maven mirror generator action. #6766
Conversation
I asked on the apache slack maven channel about an updated list of public mirrors which caused a little discussion between maven devs and also central maintainers. This lead to an update of the meta xml, which is now listing the remaining public mirrors correctly: So we could collect the mirror info from the repo xml, but since its just 3 urls it is probably ok to keep them hardcoded for now without over engineering it. |
would like to start to merge some of the smaller maven PRs this weekend, assuming they are reviewed to shrink the queue a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me.
java/maven.grammar/src/org/netbeans/modules/maven/codegen/NewMirrorPanel.java
Show resolved
Hide resolved
None of the preset mirrors for maven central exist anymore, this updates the preset to the last known public mirrors and tweaks the UI a bit. Fixed possible NPE when the central list is checked before NotificationLineSupport was attached.
9c168c7
to
a9845e3
Compare
} | ||
}); | ||
checkCentral(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sdedic to answer your question from the other PR, the NPE was here:
netbeans/java/maven.grammar/src/org/netbeans/modules/maven/codegen/NewMirrorPanel.java
Line 167 in a9845e3
nls.setErrorMessage(NbBundle.getMessage(NewProfilePanel.class, "ERR_SameMirrorId")); |
nls
was null. This can happen when the mirror already exists and the user opens the dialog again, the check will run right from the constructor, nls
is set post-construction and is therefore still null. By moving the check into addNotify()
this is avoided.
test:
open
settings.xml
via Project Files, hitalt+insert
->Mirror...