-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to JDK 22 javac (build 33). #6968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Thanks.
451a2fd
to
42f5bee
Compare
hi @lahodaj. #7019 got merged and CI should be now ready for the NB 22 cycle. Could you make this small additional change which would enable testing on JDK 22? I couldn't do this myself because nb-javac 22 would be required for that - and I think this would fit to this PR. diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 30f49a0..c72e686 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -1593,10 +1593,10 @@
timeout-minutes: 60
strategy:
matrix:
- java: [ '17', '21' ]
+ java: [ '17', '22-ea' ]
config: [ 'batch1', 'batch2' ]
exclude:
- - java: ${{ github.event_name == 'pull_request' && 'nothing' || '21' }}
+ - java: ${{ github.event_name == 'pull_request' && 'nothing' || '22-ea' }}
fail-fast: false
steps: that would be the |
42f5bee
to
0928fc9
Compare
Adjusted the GH actions, as suggested by @mbien. I'll integrate once the build is green, unless there are objections. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! thanks for updating the java version on the hints job, lets hope everything is green on 22-ea.
feel free to merge if everything is ready - master is green again.
This is a first attempt to upgrade the nb-javac to a new version based on JDK22.