Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JDK 22 javac (build 33). #6968

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jan 18, 2024

This is a first attempt to upgrade the nb-javac to a new version based on JDK22.

@lahodaj lahodaj added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) ci:all-tests [ci] enable all tests labels Jan 18, 2024
@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Jan 28, 2024
@mbien mbien added this to the NB22 milestone Jan 29, 2024
Copy link
Contributor

@dbalek dbalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks.

@dbalek dbalek changed the title Upgrade to JDK 22 javac (build 31). Upgrade to JDK 22 javac (build 33). Feb 7, 2024
@mbien
Copy link
Member

mbien commented Feb 10, 2024

hi @lahodaj. #7019 got merged and CI should be now ready for the NB 22 cycle. Could you make this small additional change which would enable testing on JDK 22? I couldn't do this myself because nb-javac 22 would be required for that - and I think this would fit to this PR.

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 30f49a0..c72e686 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -1593,10 +1593,10 @@
     timeout-minutes: 60
     strategy:
       matrix:
-        java: [ '17', '21' ]
+        java: [ '17', '22-ea' ]
         config: [ 'batch1', 'batch2' ]
         exclude:
-          - java: ${{ github.event_name == 'pull_request' && 'nothing' || '21' }}
+          - java: ${{ github.event_name == 'pull_request' && 'nothing' || '22-ea' }}
       fail-fast: false
     steps:

that would be the java-hints-test job

@lahodaj
Copy link
Contributor Author

lahodaj commented Feb 14, 2024

Adjusted the GH actions, as suggested by @mbien. I'll integrate once the build is green, unless there are objections. Thanks!

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! thanks for updating the java version on the hints job, lets hope everything is green on 22-ea.

feel free to merge if everything is ready - master is green again.

@mbien mbien added the Upgrade Library Library (Dependency) Upgrade label Feb 14, 2024
@lahodaj lahodaj merged commit 5e7b14f into apache:master Feb 16, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants