Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add petrovic-d as collaborator for Apache/NetBeans #8126

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

MartinBalin
Copy link
Contributor

Add petrovic-d as collaborator for NetBeans project
https://github.com/apache/netbeans/issues?q=is%3Apr+author%3Apetrovic-d

@MartinBalin MartinBalin added the ci:no-build [ci] disable CI pipeline label Jan 8, 2025
@MartinBalin MartinBalin requested a review from mbien January 8, 2025 09:30
@mbien
Copy link
Member

mbien commented Jan 8, 2025

Hi @petrovic-d Not sure if anyone talked to you about this yet, but here some info just in case:

The collaborator/triage role unlocks many github features like labels, CI or issue management which makes contributing a smoother experience.

Labels are of particular interest for this repo since they influence what CI will test wiki about CI and in what section the PR will appear in the release notes.

CI will also start right away when you open a PR, so please add labels before pressing open. Syncing a PR (pushing into the branch) will also take label changes into account, restarting jobs however will not.

It might take a few h after merge till the role change is picked up by github.

more info:
the collaborator role essentially maps to the github triage role.
apache wiki (asf.yaml doc, needs committer access to read)

last collaborator change: #7715

@MartinBalin MartinBalin merged commit cb84370 into apache:master Jan 9, 2025
26 checks passed
@petrovic-d
Copy link
Collaborator

@mbien It looks like that the role I have cannot add labels before opening PR

@mbien
Copy link
Member

mbien commented Jan 13, 2025

@petrovic-d interesting. We verified this back when we added our first collaborator. Lets hope it is just some caching issue on the side of github.

@mbien
Copy link
Member

mbien commented Jan 13, 2025

@petrovic-d as workaround: feel free to sync the PR after you set the labels (e.g force push a change), this will cancel the running build and start a fresh one with the new labels taken into account.

@mbien
Copy link
Member

mbien commented Jan 13, 2025

if this continues being a problem we should file a bug against github. Since having a collaborator/triage role which is able to set labels everywhere but not while using the UI of the PR creation form would make no sense.

@mbien mbien added this to the NB25 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:no-build [ci] disable CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants