Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling for TestAdapter and DBConfigurationProvider #8137

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Error handling for TestAdapter and DBConfigurationProvider #8137

merged 1 commit into from
Jan 14, 2025

Conversation

petrovic-d
Copy link
Collaborator

@petrovic-d petrovic-d commented Jan 10, 2025 •
edited
Loading

Added error handling in TestAdapter and DBConfigurationProvider when invoking commands

  • it will prevent errors, similar to the one fixed in PR, from affecting test infrastructure

Allow canceling test runs triggered by a command

@petrovic-d petrovic-d added the VSCode Extension [ci] enable VSCode Extension tests label Jan 10, 2025
@petrovic-d petrovic-d self-assigned this Jan 10, 2025
sdedic
sdedic reviewed Jan 12, 2025
View reviewed changes
Copy link
Member

@sdedic sdedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls. supply a description

@sdedic sdedic added this to the NB25 milestone Jan 12, 2025
@apache apache locked and limited conversation to collaborators Jan 13, 2025
@apache apache unlocked this conversation Jan 13, 2025
jhorvath
jhorvath approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jhorvath jhorvath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jhorvath jhorvath merged commit 11078f7 into apache:master Jan 14, 2025
62 of 63 checks passed
@jhorvath jhorvath deleted the handle-errors-in-test-adapter branch January 14, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdedic sdedic sdedic left review comments

@MartinBalin MartinBalin MartinBalin approved these changes

@jhorvath jhorvath jhorvath approved these changes

Assignees

@petrovic-d petrovic-d

Labels
VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Milestone
NB25
Development

Successfully merging this pull request may close these issues.
4 participants
@petrovic-d @jhorvath @MartinBalin @sdedic