Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payara Server instance running on WSL with deploy-on-save breaks "Web Application" Ant projects #8144

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

jGauravGupta
Copy link
Contributor

@jGauravGupta jGauravGupta commented Jan 12, 2025

This pull resolves an issue where running a Payara Server instance on WSL breaks Java Web Application projects that use Ant in Apache NetBeans.

Changes in this PR:

  • Reverted the distributeOnSave in DeployOnSaveManager implementation to remove faulty path substring logic.
  • Application path converted from /mnt to Windows system, with this fix org.netbeans.modules.j2ee.deployment.impl.ServerFileDistributor#distributeOnSave is correctly used.
  • Tooltip added to WSL and Docker checkbox.
  • WSL and Docker configuration in Payara Server Properties panel
  • DeployOnSaveManager is deprecated for Payara Micro tools and only available for older version (<2.2). For newer version dev mode support is available by default.

Reported issue: #8138
Discussion: #8121
Original PR: #7885

@jGauravGupta jGauravGupta added Java EE/Jakarta EE [ci] enable enterprise job os:windows Regression This used to work! labels Jan 12, 2025
@jGauravGupta jGauravGupta added this to the NB25 milestone Jan 12, 2025
@mbien mbien added the Ant [ci] enable "build tools" tests label Jan 12, 2025
@apache apache locked and limited conversation to collaborators Jan 12, 2025
@apache apache unlocked this conversation Jan 12, 2025
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. The problem described in the issue is not reproducible anymore, which hot deployment/copy on change still works with the payara server I registered. Thank you.

One thing I noticed while testing, was that the "Docker" and "WSL" toggles only work when creating a new server. I'm missing a toggle for these properties in the service change dialog. That problem is not introduced here, but you might consider fixing it here or in a followup.

@jGauravGupta jGauravGupta changed the title Payara Server instance running on WSL breaks "Web Application" ant projects Payara Server instance running on WSL with deploy-on-save breaks "Web Application" Ant projects Jan 16, 2025
@mbien
Copy link
Member

mbien commented Jan 16, 2025

@jGauravGupta dependent on how you want to merge this - don't forget to squash. Only mentioning it since we got merges recently where this was skipped and ~15 commits were merged by accident.

… Application" Ant projects

Revert distributeOnSave in DeployOnSaveManager
Fixes application path to distribute file on save
Tooltip for WSL and Docker
WSL and Docker configuration in Payara Server Properties panel
DeployOnSaveManager deprecated and available for older version (<2.2)
@matthiasblaesing
Copy link
Contributor

After the changes to problem is still fixed. "Instance Type" "None" sounds a bit strange for a normal installation. I think this can be merged.

@jGauravGupta jGauravGupta merged commit dbca544 into apache:master Jan 18, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ant [ci] enable "build tools" tests Java EE/Jakarta EE [ci] enable enterprise job os:windows Regression This used to work!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Payara Server instance running on WSL breaks "Web Application" ant projects
3 participants