Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NB config: disable TopSecurityManager and enable exit logging #8169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NB config: disable TopSecurityManager and enable exit logging #8169

wants to merge 1 commit into from
+1 −1

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 17, 2025 •
edited
Loading

Suggestion came up on apache slack to do another release without applying #3386 or #7928 but disabling TopSecurityManager instead.

this PR:

  • replaces -Djava.security.manager=allow' with -DTopSecurityManager.disable=trueand-Djava.lang.Runtime.level=FINE`
  • allows launching NB builds on JDK 17-24

cons:

  • contrary to Remove SecurityManager layer #7928, no tests ran on JDK 24 with this config (and CI will continue testing on JDK 23 as upper bound)
  • even though I run those flags since NB 23 on JDK 23, I didn't actually test it on JDK 24 (I tested the removal PR instead)
  • -> current confidence level regarding JDK 24 + topsec disabled: "works on my machine"

pros:

  • can be switched on again if problems are encountered

@mbien
NB config: disable TopSecurityManager and enable exit logging
7b22ad7 
 - replaces '-Djava.security.manager=allow' with
   '-DTopSecurityManager.disable=true' and
   '-Djava.lang.Runtime.level=FINE'
 - allows launching NB builds on JDK 17-24
@mbien mbien added Platform [ci] enable platform tests (platform/*) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jan 17, 2025
@mbien mbien added this to the NB25 milestone Jan 17, 2025
@mbien mbien mentioned this pull request Jan 17, 2025
Open
@matthiasblaesing
Copy link
Contributor

Would make sense from my POV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Platform [ci] enable platform tests (platform/*)
Projects
None yet
Milestone
NB25
Development

Successfully merging this pull request may close these issues.
2 participants
@mbien @matthiasblaesing