Skip to content

Commit

Permalink
Use Java Zulu distribution for all docker-tests and integration-tests…
Browse files Browse the repository at this point in the history
… Github Workflows
  • Loading branch information
ChrisSamo632 committed Oct 19, 2023
1 parent 526e723 commit 08f3105
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 24 deletions.
15 changes: 2 additions & 13 deletions .github/workflows/docker-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ on:
- 'nifi-toolkit/nifi-toolkit-assembly/**'
- 'nifi-toolkit/nifi-toolkit-cli/**'
- 'nifi-toolkit/nifi-toolkit-encrypt-config/**'
- 'nifi-toolkit/nifi-toolkit-tls/**'
- 'minifi/minifi-assembly/**'
- 'minifi/minifi-docker/**'
- 'minifi/minifi-c2/minifi-c2-assembly/**'
Expand All @@ -44,7 +43,6 @@ on:
- 'nifi-toolkit/nifi-toolkit-assembly/**'
- 'nifi-toolkit/nifi-toolkit-cli/**'
- 'nifi-toolkit/nifi-toolkit-encrypt-config/**'
- 'nifi-toolkit/nifi-toolkit-tls/**'
- 'minifi/minifi-assembly/**'
- 'minifi/minifi-docker/**'
- 'minifi/minifi-c2/minifi-c2-assembly/**'
Expand Down Expand Up @@ -87,7 +85,6 @@ env:
-pl -nifi-toolkit/nifi-toolkit-assembly
-pl -nifi-toolkit/nifi-toolkit-cli
-pl -nifi-toolkit/nifi-toolkit-encrypt-config
-pl -nifi-toolkit/nifi-toolkit-tls
-pl -minifi/minifi-assembly
-pl -minifi/minifi-c2/minifi-c2-assembly
Expand All @@ -113,26 +110,18 @@ jobs:
strategy:
fail-fast: false
matrix:
# TODO: macos-latest doesn't come with Docker and Colima seems to have problems with the nifi-docker integration_test scripts - see NIFI-12177/NIFI-12191
os: [ ubuntu-latest ]
version: [ 21 ]
timeout-minutes: 120
runs-on: ${{ matrix.os }}
name: ${{ matrix.os }} Java ${{ matrix.version }}
env:
# default to Amazon Corretto JDK
JAVA_DISTRIBUTION: corretto
steps:
# Zulu JDK appears to be more reliable for MacOS
- name: Use Java distribution Zulu
if: ${{ runner.os == 'macOS' }}
run: echo "JAVA_DISTRIBUTION=zulu" >> "$GITHUB_ENV"
- name: Checkout Code
uses: actions/checkout@v4
- name: Set up Java ${{ env.JAVA_DISTRIBUTION }} ${{ matrix.version }}
- name: Set up Java Zulu ${{ matrix.version }}
uses: actions/setup-java@v3
with:
distribution: ${{ env.JAVA_DISTRIBUTION }}
distribution: 'zulu'
java-version: ${{ matrix.version }}
cache: 'maven'

Expand Down
16 changes: 6 additions & 10 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@ env:
-pl -:nifi-system-test-suite
-pl -:nifi-nar-provider-assembly
-pl -:nifi-py4j-integration-tests
-pl -:nifi-docs
-pl -:nifi-maven-archetypes
-pl -:nifi-processor-bundle-archetype
-pl -:nifi-service-bundle-archetype
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand All @@ -86,26 +90,18 @@ jobs:
strategy:
fail-fast: false
matrix:
# TODO: macos-latest doesn't come with Docker and Colima seems to have problems with Test Containers - see NIFI-12191
os: [ ubuntu-latest ]
version: [ 21 ]
timeout-minutes: 120
runs-on: ${{ matrix.os }}
name: ${{ matrix.os }} Java ${{ matrix.version }}
env:
# default to Amazon Corretto JDK
JAVA_DISTRIBUTION: corretto
steps:
# Zulu JDK appears to be more reliable for MacOS
- name: Use Java distribution Zulu
if: ${{ runner.os == 'macOS' }}
run: echo "JAVA_DISTRIBUTION=zulu" >> "$GITHUB_ENV"
- name: Checkout Code
uses: actions/checkout@v4
- name: Set up Java ${{ env.JAVA_DISTRIBUTION }} ${{ matrix.version }}
- name: Set up Java Zulu ${{ matrix.version }}
uses: actions/setup-java@v3
with:
distribution: ${{ env.JAVA_DISTRIBUTION }}
distribution: 'zulu'
java-version: ${{ matrix.version }}
cache: 'maven'

Expand Down
1 change: 0 additions & 1 deletion .github/workflows/system-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ env:
-D skipTests
-am
MAVEN_RUN_ARGUMENTS: >-
package
verify
-P integration-tests
-D include-python-integration-tests=true
Expand Down

0 comments on commit 08f3105

Please sign in to comment.