Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12175 update Docker Image builds to Java 21, rationalise base image name and tag across all components #7864

Closed
wants to merge 2 commits into from

Conversation

ChrisSamo632
Copy link
Contributor

@ChrisSamo632 ChrisSamo632 commented Oct 10, 2023

Summary

NIFI-12175 update Docker Image builds to Java 21, rationalise base image name and tag across all components

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • [ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [ ] Documentation formatting appears as expected in rendered files

@ChrisSamo632
Copy link
Contributor Author

This PR blocks NIFI-12178 (see #7858)

@briansolo1985
Copy link
Contributor

Hi @ChrisSamo632!
Thank you for the change. I noticed that the docker images in minifi/minifi-c2/minifi-c2-docker are still using the eclipse-temurin:17-jre base image. Could we include upgrading those in this change as well?

@ChrisSamo632
Copy link
Contributor Author

@briansolo1985 thanks for the catch, thought I'd updated all of those, but evidently I either mised some or forgot to add them to the commit!

Had missed the same for nifi-registry's dockerhub file too

@briansolo1985
Copy link
Contributor

Thanks @ChrisSamo632! Looks okay from my side. +1

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these improvements @ChrisSamo632, moving the Docker Image Name and version to the root Maven configuration will definitely help keep things clear. The other changes look good. +1 merging

@ChrisSamo632 ChrisSamo632 deleted the NIFI-12175 branch November 8, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants