Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-12198 Add API and CLI commands to import reporting task snapshots #7875

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

bbende
Copy link
Contributor

@bbende bbende commented Oct 12, 2023

Summary

NIFI-12198

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Use CLI commands to export reporting tasks and then use that as input to the new command:

nifi export-reporting-tasks -o /tmp/reporting-tasks.json
nifi import-reporting-tasks -i /tmp/reporting-tasks.json

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@bbende bbende added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 12, 2023
@bbende bbende requested a review from markap14 October 12, 2023 20:31
// Nothing to verify
},
(importRequest) -> {
final VersionedReportingTaskSnapshot snapshot = importRequestEntity.getReportingTaskSnapshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to ensure that we're referencing importRequest here, not importRequestEntity. Otherwise, the request could be changed between first and second phase of the two-phase protocol

@markap14
Copy link
Contributor

Thanks for adding this in @bbende. Code review looks good, aside from the one note that I made inline about referencing the wrong entity. Still need to do some testing but in terms of the code itself, all is looking good. Will do some testing in the next day or two

@markap14
Copy link
Contributor

Was able to test and all looks good. Given that the only I had was a trivial change, I can make that change and merge if you're good with that @bbende

@bbende
Copy link
Contributor Author

bbende commented Oct 20, 2023

@markap14 yes that would be great! Really appreciate the review and testing

…/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerResource.java
@markap14 markap14 merged commit fd2de5a into apache:main Oct 20, 2023
@markap14
Copy link
Contributor

Great, thanks @bbende, merged to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants