NIFI-12242: Added ability to route data that exceeds the configured t… #7895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hreshold in ControlRate to be routed to 'rate exceeded' instead of just staying in the queue. Added Use Case documentation to ControlRate.
|
reviewing |
mosermw
reviewed
Oct 19, 2023
| For example, to allow through 8 MB per second, "Maximum Rate" to `8 MB`. | ||
| """ | ||
| ) | ||
| @UseCase(description = "Limit the rate at which requests are sent to a downstream system with little to no bursts", |
There was a problem hiding this comment.
For this UseCase, would you change the word "requests" to "flowfiles"? (there are 3 places). That would make this UseCase generic for users that don't equate a request to a flowfile. The last 2 UseCases use the word "requests" which is fine for those cases.
| Set the "Time Duration" property to `1 sec`. | ||
| Configure the "Maximum Rate" property to specify how much data should be allowed through each second. | ||
|
|
||
| For example, to allow through 8 MB per second, "Maximum Rate" to `8 MB`. |
There was a problem hiding this comment.
Missing word "set" e.g. "set Maximum Rate to '8 MB'". The word "set" is also missing in UseCase 3 and 4.
There was a problem hiding this comment.
Good catch @mosermw thanks
|
Thanks @mosermw pushed a commit that addresses the above. |
|
+1 merging to main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hreshold in ControlRate to be routed to 'rate exceeded' instead of just staying in the queue. Added Use Case documentation to ControlRate.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation