Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIFI-13952 - Flow Analysis Rule to restrict backpressure configuration #9476

Closed
wants to merge 2 commits into from
Closed

NIFI-13952 - Flow Analysis Rule to restrict backpressure configuration #9476

wants to merge 2 commits into from

Conversation

pvillard31
Copy link
Contributor

@pvillard31 pvillard31 commented Oct 31, 2024 •
edited
Loading

Summary

NIFI-13952 - Flow Analysis Rule to restrict backpressure configuration

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

mosermw
mosermw reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@mosermw mosermw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and various violations show in the UI as expected. I had one important question, a new contrib-check problem, and threw in some nit-picks for message grammar and other things.

nifi-extension-bundles/nifi-standard-bundle/nifi-standard-rules/pom.xml Show resolved Hide resolved
...ard-rules/src/main/resources/META-INF/services/org.apache.nifi.flowanalysis.FlowAnalysisRule Outdated Show resolved Hide resolved
...ard-rules/src/main/java/org/apache/nifi/flowanalysis/rules/RestrictBackpressureSettings.java Outdated Show resolved Hide resolved
...ard-rules/src/main/java/org/apache/nifi/flowanalysis/rules/RestrictBackpressureSettings.java Outdated Show resolved Hide resolved
...ard-rules/src/main/java/org/apache/nifi/flowanalysis/rules/RestrictBackpressureSettings.java Outdated Show resolved Hide resolved
...ard-rules/src/main/java/org/apache/nifi/flowanalysis/rules/RestrictBackpressureSettings.java Outdated Show resolved Hide resolved
...ard-rules/src/main/java/org/apache/nifi/flowanalysis/rules/RestrictBackpressureSettings.java Show resolved Hide resolved
@pvillard31
Copy link
Contributor Author

Thanks for the review @mosermw ! I have addressed/answered your comments and rebased on main to have the latest checkstyle/PMD rules.

@mosermw
Copy link
Member

mosermw commented Jan 22, 2025

+1 merging. Looking forward to using this rule and future Flow Analysis Rules.

asfgit pushed a commit that referenced this pull request Jan 22, 2025
@pvillard31 @mosermw
NIFI-13952 - Flow Analysis Rule to restrict backpressure configuration (
10ca335 
#9476)

Signed-off-by: Mike Moser <mosermw@apache.org>
@mosermw mosermw closed this Jan 22, 2025
@pvillard31
Copy link
Contributor Author

Thanks @mosermw !

@pvillard31 pvillard31 deleted the NIFI-13952 branch January 22, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosermw mosermw mosermw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvillard31 @mosermw