Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] use python-3.10 #353

Merged
merged 1 commit into from
Nov 16, 2023
Merged

[ci] use python-3.10 #353

merged 1 commit into from
Nov 16, 2023

Conversation

hrsakai
Copy link
Contributor

@hrsakai hrsakai commented Nov 16, 2023

Motivation

Currently, following jobs are failed.

Build NAPI macos - Node 18 - arm64
Build NAPI macos - Node 18 - x64
Build NAPI macos with CPP lib installed by Homebrew 

log

gyp info using node-gyp@9.4.0
gyp info using node@18.18.2 | darwin | x64
gyp info find Python using Python version 3.12.0 found at "/usr/local/bin/python3"
.
.
.
  File "/Users/runner/hostedtoolcache/node/18.18.2/x64/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py", line 42, in <module>
    import gyp  # noqa: E402
    ^^^^^^^^^^
  File "/Users/runner/hostedtoolcache/node/18.18.2/x64/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 9, in <module>
    import gyp.input
  File "/Users/runner/hostedtoolcache/node/18.18.2/x64/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 19, in <module>
    from distutils.version import StrictVersion
ModuleNotFoundError: No module named 'distutils'
gyp ERR! configure error 
gyp ERR! stack Error: `gyp` failed with exit code: 1

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@hrsakai hrsakai self-assigned this Nov 16, 2023
@hrsakai hrsakai added this to the 1.10.0 milestone Nov 16, 2023
@shibd shibd merged commit 801e5ce into apache:master Nov 16, 2023
12 checks passed
@hrsakai hrsakai deleted the use-python-3.10 branch November 16, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants