QPID-8538: Replenish the credit after drain by the drained amount of messages #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related JIRA https://issues.apache.org/jira/browse/QPID-8538. |
jiridanek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the fetch code, which causes the drain to end by the call of the GET which top-up credit only by 1. If there is queued e.g 1-2 messages queued from broker and local client gave up whole credit by the drain cycle, it must be always replenished by the real amount of messages drained from broker, otherwise the fetch method is ended with credit 1 or 0. Then the performance is degraded to very small.
You can do whatever with this PR, consider this as free of charge contribution for open source community.