[SPARK-50751][SQL] Assign appropriate error condition for _LEGACY_ERROR_TEMP_1305: UNSUPPORTED_TABLE_CHANGE_IN_JDBC_CATALOG
#49395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OR_TEMP_1305: UNSUPPORTED_TABLE_CHANGE_IN_JDBC_CATALOG
MaxGekk
reviewed
Jan 10, 2025
...rc/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala
Outdated
Show resolved
Hide resolved
MaxGekk
approved these changes
Jan 21, 2025
|
+1, LGTM. Merging to master/4.0. |
MaxGekk
pushed a commit
that referenced
this pull request
Jan 21, 2025
…ROR_TEMP_1305`: `UNSUPPORTED_TABLE_CHANGE_IN_JDBC_CATALOG` ### What changes were proposed in this pull request? This PR proposes to assign appropriate error condition for `_LEGACY_ERROR_TEMP_1305`: `UNSUPPORTED_TABLE_CHANGE_IN_JDBC_CATALOG` and improve its error message ### Why are the changes needed? To improve the error message by assigning proper error condition and SQLSTATE ### Does this PR introduce _any_ user-facing change? No, only user-facing error message improved ### How was this patch tested? Updated the existing tests ### Was this patch authored or co-authored using generative AI tooling? No Closes #49395 from itholic/LEGACY_1305. Authored-by: Haejoon Lee <haejoon.lee@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit ce07396) Signed-off-by: Max Gekk <max.gekk@gmail.com>
|
Thanks @MaxGekk for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to assign appropriate error condition for
_LEGACY_ERROR_TEMP_1305:UNSUPPORTED_TABLE_CHANGE_IN_JDBC_CATALOGand improve its error messageWhy are the changes needed?
To improve the error message by assigning proper error condition and SQLSTATE
Does this PR introduce any user-facing change?
No, only user-facing error message improved
How was this patch tested?
Updated the existing tests
Was this patch authored or co-authored using generative AI tooling?
No