feat: support DetectToxicContent #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luacheck Report2 tests 2 ✅ 0s ⏱️ Results for commit 4eeed8c. ♻️ This comment has been updated with latest results. |
| @@ -78,6 +78,66 @@ local aws_config = { | |||
| api = {}, | |||
| } | |||
|
|
|||
| local detect_toxic_content_spec = { | |||
There was a problem hiding this comment.
lua table representation of ToxicContent operation.
It can be found here too:
https://github.com/aws/aws-sdk-js-v3/blob/0899e938946741970e9bb4ad27c4ec8966ccbc09/codegen/sdk-codegen/aws-models/comprehend.json#L4977
src/resty/aws/request/build.lua
Outdated
| @@ -106,7 +106,7 @@ local function build_request(operation, config, params) | |||
| local body_tbl = {} | |||
|
|
|||
| if config.signingName or config.targetPrefix then | |||
| request.headers["X-Amz-Target"] = (config.signingName or config.targetPrefix) .. "." .. operation.name | |||
| request.headers["X-Amz-Target"] = (config.targetPrefix or config.signingName) .. "." .. operation.name | |||
There was a problem hiding this comment.
the x-amz-target should have the Comprehend_20171127 prefix. In this case targetPrefix has the Comprehend_20171127 value.
There was a problem hiding this comment.
hmm, I cannot confirm this. I should change the order only for DetectToxicity then.
nic-6443
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.