This repository has been archived by the owner on Dec 20, 2022. It is now read-only.
Eclipse Upgrade 2019-09 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back merge
Back merge
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
===========================================
+ Coverage 9.13% 9.14% +<.01%
Complexity 160 160
===========================================
Files 98 98
Lines 5679 5678 -1
Branches 705 705
===========================================
Hits 519 519
+ Misses 5108 5107 -1
Partials 52 52
Continue to review full report at Codecov.
|
bundles/org.aposin.mergeprocessor/src/org/aposin/mergeprocessor/application/Activator.java
Show resolved
Hide resolved
features/org.aposin.mergeprocessor.thirdparty.feature/feature.xml
Outdated
Show resolved
Hide resolved
...org.aposin.mergeprocessor.targetdefinition/org.aposin.mergeprocessor.targetdefinition.target
Show resolved
Hide resolved
d-gs
previously approved these changes
Oct 15, 2019
There was a problem hiding this comment.
Approved, but some questions remaining: feel free to merge if they aren't relevant or apply needed changes! Thanks @StefanFranzWeiser!
features/org.aposin.mergeprocessor.thirdparty.feature/feature.xml
Outdated
Show resolved
Hide resolved
...org.aposin.mergeprocessor.targetdefinition/org.aposin.mergeprocessor.targetdefinition.target
Show resolved
Hide resolved
bundles/org.aposin.mergeprocessor/src/org/aposin/mergeprocessor/application/Activator.java
Show resolved
Hide resolved
StefanFranzWeiser
force-pushed
the
eclipse_201909_upgrade
branch
from
308377d to
aa9feaa
Compare
d-gs
approved these changes
Oct 16, 2019
|
Thanks @StefanFranzWeiser - LGTM and merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of request
Related Issue(s)
Concept
Library upgrades
Description of the change
Upgrade Targetplatform from Eclipse 4.11 to 4.13
Upgrade commons-collections4 from 4.3 to 4.4
Description of current state
Product based on Eclipse 4.11
commons-collections4 v4.3 used
Description of target state
Product based on Eclipse 4.13
commons-collections4 v4.4 used
Estimated investment / approximate investment
Initiator
name / company / position / created at
Technical information
Platform / target area
known side-effects
org.eclipse.textandorg.eclipse.jface.textmust be added to own thirdparty feature, as it is not shipped with featureorg.eclipse.rcpanymore (see https://bugs.eclipse.org/bugs/show_bug.cgi?id=552134).other
DB Changes (if so: incl. scripts with definitions and testdata)
How has this Tested?
All existing JUnit-Tests run green.
Product can be started without errors.
Screenshots, Uploads, other documents (if appropriate):
Checklist: