Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phillmv the query you asked me to look at came from the EmailManager which found every user that had outstanding notifications that wanted them before building a vuln/patched email for each of those users.
In building the email, we query the notifications table again for each account:
Seeing that, it seems like the fastest fix here is to just get rid of the the slow query that tries to guess which accounts have notifications to send and just do the faster query (scoped to the last 2 days of events) for every account.
Can you sanity check this?