Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target SDK 33 #109

Merged
merged 2 commits into from
May 10, 2024
Merged

Target SDK 33 #109

merged 2 commits into from
May 10, 2024

Conversation

Dor-bl
Copy link
Contributor

@Dor-bl Dor-bl commented May 9, 2024

Removed deprecated buildToolsVersion
replaced compileSdkVersion with compileSdk
Target SDK 33
Bump appcompat from 1.4.2 to 1.6.1
Bump versionName to 4.2.0

Dor-bl added 2 commits May 9, 2024 23:52
Remove deprecated `buildToolsVersion`
and replace `compileSdkVersion`  with `compileSdk`
Target SDK 33
Bump `appcompat` from 1.4.2 to 1.6.1
@mykola-mokhnach mykola-mokhnach merged commit c0d4c76 into appium:master May 10, 2024
2 checks passed
@Dor-bl Dor-bl deleted the target_sdk_33 branch May 10, 2024 07:53
@Dor-bl
Copy link
Contributor Author

Dor-bl commented May 10, 2024

@KazuCocoa @mykola-mokhnach I think I missed updating the corresponding app version here: https://github.com/appium/android-apidemos/blob/master/package.json#L3

@mykola-mokhnach
Copy link
Contributor

This version must not be updated manually. It is a part of the package publishing flow

@mykola-mokhnach
Copy link
Contributor

I would also advice to sync android package version bump with npm version bump similarly to how it's done in https://github.com/appium/io.appium.settings/blob/5d3bc99ff35f3b816b4342395aba1bdea82ad48f/package.json#L15

@Dor-bl
Copy link
Contributor Author

Dor-bl commented May 11, 2024

So you usually change the ${npm_package_version} value and run the command?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants