Skip to content

Commit

Permalink
refactor: Isolate base Android functionality (#901)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Removed androidHelpers export. Corresponding methods are now integrated into the driver
BREAKING CHANGE: Removed webviewHelpers export. Corresponding methods are now integrated into the driver
BREAKING CHANGE: Removed redundant exports related to io.appium.settings.
BREAKING CHANGE: Removed deprecated APIs related to launchApp/closeApp/reset
BREAKING CHANGE: Removed the unused unlocker property from the driver.

The mixin typesystem has been aligned. There are no explicit mixin definitions, which basically duplicate each method signature. Instead all types are now provided next to method definitions.

Improved grouping of different commands. Made it more explicit which of them are designed for export and which are just internal helpers

Improved helper methods design, so they don't need to retrieve driver-specific properties (like log or adb) via command line args, but use this context and explicit binding instead.

Marked legacy JWP touch-related methods as deprecated. They must be eventually replaced with proper W3C implementations.

Removed unused declarations for non-implemented methods.
  • Loading branch information
mykola-mokhnach authored Jan 24, 2024
1 parent 71dd941 commit 70e6233
Show file tree
Hide file tree
Showing 78 changed files with 7,691 additions and 8,722 deletions.
244 changes: 0 additions & 244 deletions lib/commands/actions.js

This file was deleted.

34 changes: 0 additions & 34 deletions lib/commands/alert.js

This file was deleted.

Loading

0 comments on commit 70e6233

Please sign in to comment.