Skip to content

Commit

Permalink
fix: review
Browse files Browse the repository at this point in the history
  • Loading branch information
@KazuCocoa
KazuCocoa committed Jan 26, 2024
1 parent 24eebe1 commit 7864378
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions lib/commands/device/common.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export async function getDeviceInfoFromCaps() {
((!_.includes(this.opts.platformVersion, '.') &&
/** @type {semver.SemVer} */ (semverPV).major ===
/** @type {semver.SemVer} */ (semverDO).major) ||
(/** @type {semver.SemVer} */ (semverPV).major ===
/** @type {semver.SemVer} */ ((semverPV).major ===

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (20) 

Conversion of type 'boolean' to type 'SemVer' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (20) 

Property 'major' does not exist on type 'string | SemVer'.

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (18) 

Conversion of type 'boolean' to type 'SemVer' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (18) 

Property 'major' does not exist on type 'string | SemVer'.

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (16) 

Conversion of type 'boolean' to type 'SemVer' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (16) 

Property 'major' does not exist on type 'string | SemVer'.

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (20) 

Conversion of type 'boolean' to type 'SemVer' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (20) 

Property 'major' does not exist on type 'string | SemVer'.

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (18) 

Conversion of type 'boolean' to type 'SemVer' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (18) 

Property 'major' does not exist on type 'string | SemVer'.

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (16) 

Conversion of type 'boolean' to type 'SemVer' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.

Check failure on line 90 in lib/commands/device/common.js

View workflow job for this annotation

GitHub Actions / test (16) 

Property 'major' does not exist on type 'string | SemVer'.
/** @type {semver.SemVer} */ (semverDO).major &&
/** @type {semver.SemVer} */ (semverPV).minor ===
/** @type {semver.SemVer} */ (semverDO).minor)) &&
Expand Down Expand Up @@ -127,12 +127,11 @@ export async function getDeviceInfoFromCaps() {

/**
* @this {AndroidDriver}
* @property {(AndroidDriverOpts & {emPort?: number})?} [opts=null]
* @returns {Promise<import('appium-adb').ADB>}
*/
export async function createADB() {
// @ts-expect-error do not put arbitrary properties on opts
const {udid, emPort} = this.opts ?? {};
const {udid, emPort} = this.opts;
const adb = await createBaseADB(this.opts);
adb.setDeviceId(udid ?? '');
if (emPort) {
Expand Down

0 comments on commit 7864378

Please sign in to comment.