Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop parsing unreachable webview names #900

Merged

Conversation

yaumu3
Copy link
Contributor

@yaumu3 yaumu3 commented Jan 18, 2024

Intent

Currently, getContexts returns the webview names including the unreachable ones. This PR modifies the behavior not to return those.

Confirmed

  • ✅ unit test

With Android emulator,

  1. Make an unreachable webview socket by the procedure described in https://issuetracker.google.com/issues/320819731
  2. Verify getContexts doesn't return the unreachable webview name

@yaumu3 yaumu3 force-pushed the fix-dont-parse-unreachable-webview-names branch from 84ebbb5 to f491f1f Compare January 18, 2024 07:37
@yaumu3 yaumu3 marked this pull request as ready for review January 18, 2024 08:57
@mykola-mokhnach mykola-mokhnach merged commit bd914de into appium:master Jan 22, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 22, 2024
## [7.8.3](v7.8.2...v7.8.3) (2024-01-22)

### Bug Fixes

* stop parsing unreachable webview names ([#900](#900)) ([bd914de](bd914de))
Copy link

🎉 This PR is included in version 7.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants