Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support user for mobile isAppInstalled #932

Merged
merged 3 commits into from
May 9, 2024

Conversation

KazuCocoa
Copy link
Member

@@ -110,5 +110,5 @@ export async function executeMobile(mobileCommand, opts = {}) {
`Only ${_.keys(mobileCommandsMapping)} commands are supported.`,
);
}
return await this[mobileCommandsMapping[mobileCommand]](opts);
return await this[/**@type {string}*/(mobileCommandsMapping[mobileCommand])](opts);
Copy link
Member Author

@KazuCocoa KazuCocoa May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to not fail to build

* @returns {Promise<boolean>}
*/
export async function isAppInstalled(appId) {
return await this.adb.isAppInstalled(appId);
export async function isAppInstalled(appId, opts) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should opts have a default value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, 2cfe880

@mykola-mokhnach
Copy link
Contributor

isAppInstaled -> isAppInstalled

@KazuCocoa KazuCocoa changed the title feat: support user for mobile isAppInstaled feat: support user for mobile isAppInstalled May 9, 2024
@KazuCocoa KazuCocoa merged commit d1bbeea into master May 9, 2024
10 checks passed
@KazuCocoa KazuCocoa deleted the add-user-appinstalled branch May 9, 2024 16:24
github-actions bot pushed a commit that referenced this pull request May 9, 2024
## [9.3.0](v9.2.0...v9.3.0) (2024-05-09)

### Features

* support user for mobile isAppInstalled ([#932](#932)) ([d1bbeea](d1bbeea))
Copy link

github-actions bot commented May 9, 2024

🎉 This PR is included in version 9.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants