-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support user for mobile isAppInstalled #932
Conversation
@@ -110,5 +110,5 @@ export async function executeMobile(mobileCommand, opts = {}) { | |||
`Only ${_.keys(mobileCommandsMapping)} commands are supported.`, | |||
); | |||
} | |||
return await this[mobileCommandsMapping[mobileCommand]](opts); | |||
return await this[/**@type {string}*/(mobileCommandsMapping[mobileCommand])](opts); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to not fail to build
lib/commands/app-management.js
Outdated
* @returns {Promise<boolean>} | ||
*/ | ||
export async function isAppInstalled(appId) { | ||
return await this.adb.isAppInstalled(appId); | ||
export async function isAppInstalled(appId, opts) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should opts have a default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, 2cfe880
isAppInstaled -> isAppInstalled |
## [9.3.0](v9.2.0...v9.3.0) (2024-05-09) ### Features * support user for mobile isAppInstalled ([#932](#932)) ([d1bbeea](d1bbeea))
🎉 This PR is included in version 9.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
appium/appium-adb#739