Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Streamline page selection #2440

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

mykola-mokhnach
Copy link
Contributor

Fixed the async call to selectPage to avoid linter errors and to properly assign the value of this.selectingNewPage.

Also refactored the isUrlIgnored call to make the method more readable

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to find

lib/commands/context.js Show resolved Hide resolved
@mykola-mokhnach mykola-mokhnach merged commit 2564829 into appium:master Aug 1, 2024
18 checks passed
@mykola-mokhnach mykola-mokhnach deleted the ref_pages branch August 1, 2024 17:14
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
## [7.24.9](v7.24.8...v7.24.9) (2024-08-01)

### Bug Fixes

* Streamline page selection ([#2440](#2440)) ([2564829](2564829))
Copy link
Contributor

github-actions bot commented Aug 1, 2024

🎉 This issue has been resolved in version 7.24.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants