test: Replace existing NUnit assertions with updated ones to align with NUnit 4 standards. #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d391711.
…th NUnit 4 standards.
KazuCocoa
approved these changes
Dec 22, 2023
| Assert.AreEqual(settings[AutomatorSetting.WaitForIDLETimeout], 3500); | ||
| Assert.AreEqual(settings[AutomatorSetting.WaitForSelectorTimeout], 5000); | ||
| Assert.AreEqual(settings[AutomatorSetting.WaitScrollAcknowledgmentTimeout], 7000); | ||
| Assert.Multiple(() => |
There was a problem hiding this comment.
Tell that to NUnit Analyzer 😅
Dor-bl
commented
Dec 22, 2023
There was a problem hiding this comment.
@KazuCocoa fixed an issue I found before the merge. please approve if needed
…lityToDefineTheDesiredLogFile improvements
Dor-bl
commented
Dec 22, 2023
There was a problem hiding this comment.
@KazuCocoa, @laolubenson Another issue I fixed just now.
KazuCocoa
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
once this PR is merged we can merge #708 as well.
Types of changes
What types of changes are you proposing/introducing to the .NET client?
Put an
xin the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Please provide more details about changes if it is necessary. If there are new features you can provide code samples showing how they work and possible use cases. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub