Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump eslint #444

Merged
merged 3 commits into from
Jan 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintignore

This file was deleted.

22 changes: 0 additions & 22 deletions .eslintrc.json

This file was deleted.

1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
save-exact=true
package-lock=false
5 changes: 5 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import appiumConfig from '@appium/eslint-config-appium-ts';

export default [
...appiumConfig,
];
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"source-map-support": "^0.x"
},
"devDependencies": {
"@appium/eslint-config-appium-ts": "^0.x",
"@appium/eslint-config-appium-ts": "^1.0.0",
"@appium/tsconfig": "^0.x",
"@appium/types": "^0.x",
"@semantic-release/changelog": "^6.0.3",
Expand Down
10 changes: 5 additions & 5 deletions test/subproc-specs.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ describe('SubProcess', function () {
afterEach(async function () {
try {
await subproc.stop();
} catch (ign) {}
} catch {}
});
it('should get output as params', async function () {
await new B(async (resolve, reject) => {
Expand All @@ -176,7 +176,7 @@ describe('SubProcess', function () {
await subproc.start();
}).should.eventually.not.be.rejected;
});
it('should get output as params', async function () {
it('should get output as params with args', async function () {
await new B(async (resolve, reject) => {
subproc = new SubProcess(getFixture('echo'), ['foo', 'bar']);
subproc.on('output', (stdout, stderr) => {
Expand Down Expand Up @@ -241,10 +241,10 @@ describe('SubProcess', function () {
// 1 for the trap, 1 for the tail
try {
await exec('kill', ['-9', String(/** @type {number} */(/** @type {NonNullable<SubProcess['proc']>} */(subproc.proc).pid) + 1)]);
} catch (ign) {}
} catch {}
try {
await exec('kill', ['-9', String(/** @type {NonNullable<SubProcess['proc']>} */(subproc.proc).pid)]);
} catch (ign) {}
} catch {}
});

it('should error if there is no process to stop', async function () {
Expand Down Expand Up @@ -373,7 +373,7 @@ describe('SubProcess', function () {
await exec('pkill', ['-f', `tail -f ${path.resolve(__filename)}`]);
try {
await proc.join();
} catch (ign) {}
} catch {}
exitCaught.should.eql([null, 'SIGTERM']);
dieCaught.should.eql(exitCaught);
stopCaught.should.be.false;
Expand Down
Loading