Skip to content

Commit

Permalink
chore(deps-dev): update rubocop requirement from = 1.68.0 to = 1.69.0 (
Browse files Browse the repository at this point in the history
…#577)

* chore(deps-dev): update rubocop requirement from = 1.68.0 to = 1.69.0

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.68.0...v1.69.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix rubocop

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kazuaki Matsuo <fly.49.89.over@gmail.com>
  • Loading branch information
dependabot[bot] and KazuCocoa authored Nov 28, 2024
1 parent 3c85ff0 commit 3166df8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion appium_lib_core.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'minitest-reporters', '~> 1.1'
spec.add_development_dependency 'parallel_tests'
spec.add_development_dependency 'rake', '~> 13.0'
spec.add_development_dependency 'rubocop', '1.68.0'
spec.add_development_dependency 'rubocop', '1.69.0'
spec.add_development_dependency 'simplecov'
spec.add_development_dependency 'steep', '~> 1.7.0'
spec.add_development_dependency 'webmock', '~> 3.24.0'
Expand Down
2 changes: 0 additions & 2 deletions lib/appium_lib_core/driver.rb
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,6 @@ def setup_for_new_session(opts = {})

def start_driver(server_url: nil,
http_client_ops: { http_client: nil, open_timeout: 999_999, read_timeout: 999_999 })

@custom_url ||= "http://127.0.0.1:#{@port}/wd/hub"
@custom_url = server_url unless server_url.nil?

Expand Down Expand Up @@ -446,7 +445,6 @@ def start_driver(server_url: nil,
# Attach to an existing session
def attach_to(session_id, url: nil, automation_name: nil, platform_name: nil,
http_client_ops: { http_client: nil, open_timeout: 999_999, read_timeout: 999_999 })

raise ::Appium::Core::Error::ArgumentError, 'The :url must not be nil' if url.nil?
raise ::Appium::Core::Error::ArgumentError, 'The :automation_name must not be nil' if automation_name.nil?
raise ::Appium::Core::Error::ArgumentError, 'The :platform_name must not be nil' if platform_name.nil?
Expand Down

0 comments on commit 3166df8

Please sign in to comment.