Deprecate unused DefaultNettyConnection#initChannel(...) overload (#…

…2489)

Motivation:

#2473 added a new overload for `initChannel`, but forgot to deprecate the previous one
and update javadoc to point to the latest overload we use.

servicetalk-transport-netty-internal/src/main/java/io/servicetalk/transport/netty/internal/DefaultNettyConnection.java

@@ -371,8 +371,8 @@ private static <Read, Write> DefaultNettyConnection<Read, Write> initChildChanne
      * @param <Write> Type of objects written to the {@link NettyConnection}.
      * @return A {@link Single} that completes with a {@link DefaultNettyConnection} after the channel is activated and
      * ready to use.
-     * @deprecated Use {@code #initChannel(Channel, BufferAllocator, Executor, IoExecutor, CloseHandler, FlushStrategy,
-     * long, SslConfig, ChannelInitializer, ExecutionStrategy, Protocol, ConnectionObserver, boolean, Predicate)}.
+     * @deprecated Use {@code #initChannel(Channel, ExecutionContext, CloseHandler, FlushStrategy, long, SslConfig,
+     * ChannelInitializer, Protocol, ConnectionObserver, boolean, Predicate)}.
      */
     @Deprecated // FIXME: 0.43 - remove deprecated method
     public static <Read, Write> Single<DefaultNettyConnection<Read, Write>> initChannel(
@@ -405,8 +405,8 @@ public static <Read, Write> Single<DefaultNettyConnection<Read, Write>> initChan
      * @param <Write> Type of objects written to the {@link NettyConnection}.
      * @return A {@link Single} that completes with a {@link DefaultNettyConnection} after the channel is activated and
      * ready to use.
-     * @deprecated Use {@code #initChannel(Channel, BufferAllocator, Executor, IoExecutor, CloseHandler, FlushStrategy,
-     * long, SslConfig, ChannelInitializer, ExecutionStrategy, Protocol, ConnectionObserver, boolean, Predicate)}.
+     * @deprecated Use {@code #initChannel(Channel, ExecutionContext, CloseHandler, FlushStrategy, long, SslConfig,
+     * ChannelInitializer, Protocol, ConnectionObserver, boolean, Predicate)}.
      */
     @Deprecated // FIXME: 0.43 - remove deprecated method
     public static <Read, Write> Single<DefaultNettyConnection<Read, Write>> initChannel(
@@ -440,7 +440,10 @@ public static <Read, Write> Single<DefaultNettyConnection<Read, Write>> initChan
      * @param <Write> Type of objects written to the {@link NettyConnection}.
      * @return A {@link Single} that completes with a {@link DefaultNettyConnection} after the channel is activated and
      * ready to use.
+     * @deprecated Use {@code #initChannel(Channel, ExecutionContext, CloseHandler, FlushStrategy, long, SslConfig,
+     * ChannelInitializer, Protocol, ConnectionObserver, boolean, Predicate)}.
      */
+    @Deprecated
     public static <Read, Write> Single<DefaultNettyConnection<Read, Write>> initChannel(
             Channel channel, BufferAllocator allocator, Executor executor, @Nullable IoExecutor ioExecutor,
             CloseHandler closeHandler, FlushStrategy flushStrategy, long idleTimeoutMs,