[GHA] Configure license check #591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
force-pushed
the
fb-gha-license-check
branch
from
9ac5f70 to
2c615f2
Compare
FranzBusch
force-pushed
the
fb-gha-license-check
branch
from
2c615f2 to
1168b15
Compare
FranzBusch
commented
Jul 12, 2024
FranzBusch
force-pushed
the
fb-gha-license-check
branch
from
0bf134f to
9d7b6e8
Compare
simonjbeaumont
approved these changes
Jul 15, 2024
Comment on lines
+12
to
+13
| unacceptable_language_check_enabled: false |
There was a problem hiding this comment.
Are we doing opt-out? Seems like it might be pretty bad to do that since we'll introduce CI breakages for adopters of the reusable workflow when we add new things that they don't want and/or can't use for some reason.
There was a problem hiding this comment.
Adopters can lock to a specific commit hash, I believe, instead of depending on main.
I think it's fair to discuss which steps are opt-out (those that we expect/want all repos to have) and opt-in (optional steps that only some repos need).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.