-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for XML request body and response body #664
Open
ugocottin
wants to merge
5
commits into
apple:main
Choose a base branch
from
ugocottin:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -56,9 +56,14 @@ struct ContentType: Hashable { | |||||||||||
/// The type is encoded as an async sequence of parts. | ||||||||||||
case multipart | ||||||||||||
|
||||||||||||
/// A content type for XML. | ||||||||||||
/// | ||||||||||||
/// The bytes are provided to a CustomCoder. | ||||||||||||
case xml | ||||||||||||
|
||||||||||||
/// Creates a category from the provided type and subtype. | ||||||||||||
/// | ||||||||||||
/// First checks if the provided content type is a JSON, then text, | ||||||||||||
/// First checks if the provided content type is a JSON, then XML, then text, | ||||||||||||
/// and uses binary if none of the two match. | ||||||||||||
/// - Parameters: | ||||||||||||
/// - lowercasedType: The first component of the MIME type. | ||||||||||||
|
@@ -68,6 +73,10 @@ struct ContentType: Hashable { | |||||||||||
if (lowercasedType == "application" && lowercasedSubtype == "json") || lowercasedSubtype.hasSuffix("+json") | ||||||||||||
{ | ||||||||||||
self = .json | ||||||||||||
} else if (lowercasedType == "application" && lowercasedSubtype == "xml") | ||||||||||||
|| lowercasedSubtype.hasSuffix("+xml") | ||||||||||||
{ | ||||||||||||
self = .xml | ||||||||||||
} else if lowercasedType == "application" && lowercasedSubtype == "x-www-form-urlencoded" { | ||||||||||||
self = .urlEncodedForm | ||||||||||||
} else if lowercasedType == "multipart" && lowercasedSubtype == "form-data" { | ||||||||||||
|
@@ -84,6 +93,7 @@ struct ContentType: Hashable { | |||||||||||
case .binary: return .binary | ||||||||||||
case .urlEncodedForm: return .urlEncodedForm | ||||||||||||
case .multipart: return .multipart | ||||||||||||
case .xml: return .xml | ||||||||||||
} | ||||||||||||
} | ||||||||||||
} | ||||||||||||
|
@@ -215,11 +225,17 @@ struct ContentType: Hashable { | |||||||||||
/// is a multipart form. | ||||||||||||
var isMultipart: Bool { category == .multipart } | ||||||||||||
|
||||||||||||
/// A Boolean value that indicates whether the content type | ||||||||||||
/// is a type of XML. | ||||||||||||
var isXML: Bool { category == .xml } | ||||||||||||
|
||||||||||||
/// The content type `text/plain`. | ||||||||||||
static var textPlain: Self { try! .init(string: "text/plain") } | ||||||||||||
|
||||||||||||
/// The content type `application/json`. | ||||||||||||
static var applicationJSON: Self { try! .init(string: "application/json") } | ||||||||||||
/// The content type `application/xml`. | ||||||||||||
Comment on lines
236
to
+237
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
static var applicationXML: Self { try! .init(string: "application/xml") } | ||||||||||||
|
||||||||||||
/// The content type `application/octet-stream`. | ||||||||||||
static var applicationOctetStream: Self { try! .init(string: "application/octet-stream") } | ||||||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,9 @@ For any other formats, the payload is provided as raw bytes (using the `HTTPBody | |
- when content type is `application/x-www-form-urlencoded` | ||
- [x] multipart | ||
- for details, see [SOAR-0009](https://swiftpackageindex.com/apple/swift-openapi-generator/main/documentation/swift-openapi-generator/soar-0009) | ||
- [ ] XML | ||
- [X] XML | ||
- when content type is `application/xml` or ends with `+xml` | ||
- xmlCoder must be provided to `OpenAPIRuntime.Configuration` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, please also add a note to the section |
||
|
||
### OpenAPI specification features | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.