Skip to content

Commit

Permalink
fix(build): Allow non-pipeline apps to be built (#75)
Browse files Browse the repository at this point in the history
  • Loading branch information
CuriousLearner authored Sep 3, 2024
1 parent 57c2d59 commit 4d91b6a
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [4.6.2] - 2024-09-03

### Fixed

* Allow `apppack build` commands to work for non-pipeline apps.

## [4.6.1] - 2024-08-28

### Fixed
Expand Down
10 changes: 6 additions & 4 deletions cmd/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -627,12 +627,14 @@ var buildStartCmd = &cobra.Command{
}
a, err := app.Init(AppName, UseAWSCredentials, duration)
checkErr(err)
if a.Pipeline && a.ReviewApp == nil {
err := fmt.Errorf("%q is a pipeline. You can build ReviewApps within a pipeline", a.Name)
if a.Pipeline {
if a.ReviewApp == nil {
err := fmt.Errorf("%q is a pipeline. You can build ReviewApps within a pipeline", a.Name)
checkErr(err)
}
_, err = a.ReviewAppExists()
checkErr(err)
}
_, err = a.ReviewAppExists()
checkErr(err)
build, err := a.StartBuild(false)
checkErr(err)
ui.Spinner.Stop()
Expand Down

0 comments on commit 4d91b6a

Please sign in to comment.