Fix LB priorities and leave gap for custom rules

Leave 1-200 empty for users to create their own custom rules. Forgot to generate a seed for review app rules.
apppackio · Apr 9, 2021 · d430db6 · d430db6
1 parent 2e4c915
commit d430db6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/cmd/create.go b/cmd/create.go
@@ -982,7 +982,7 @@ func createAppOrPipeline(cmd *cobra.Command, args []string, pipeline bool) {
 			},
 			{
 				ParameterKey:   aws.String("LoadBalancerRulePriority"),
-				ParameterValue: aws.String(fmt.Sprintf("%d", rand.Intn(50000-1)+1)), // TODO: verify empty slot
+				ParameterValue: aws.String(fmt.Sprintf("%d", rand.Intn(50000-200)+200)), // TODO: verify empty slot
 			},
 			{
 				ParameterKey:   aws.String("Name"),

diff --git a/cmd/reviewapps.go b/cmd/reviewapps.go
@@ -19,6 +19,7 @@ import (
 	"fmt"
 	"math/rand"
 	"strings"
+	"time"
 
 	"github.com/apppackio/apppack/app"
 	"github.com/aws/aws-sdk-go/aws"
@@ -186,6 +187,7 @@ var reviewappsCreateCmd = &cobra.Command{
 		checkErr(err)
 		parameters, err := pipelineCfnParameters(stack)
 		checkErr(err)
+		rand.Seed(time.Now().UnixNano())
 		parameters = append(parameters, []*cloudformation.Parameter{
 			{
 				ParameterKey:   aws.String("Name"),
@@ -197,7 +199,7 @@ var reviewappsCreateCmd = &cobra.Command{
 			},
 			{
 				ParameterKey:   aws.String("LoadBalancerRulePriority"),
-				ParameterValue: aws.String(fmt.Sprintf("%d", rand.Intn(50000-1)+1)),
+				ParameterValue: aws.String(fmt.Sprintf("%d", rand.Intn(50000-200)+200)),
 			},
 		}...)
 		err = createStackOrChangeSet(a.Session, &cloudformation.CreateStackInput{