-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Separate types from implementations to reduce cyclic dependencies #38544
base: release
Are you sure you want to change the base?
refactor: Separate types from implementations to reduce cyclic dependencies #38544
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This PR has increased the number of cyclic dependencies by 31, when compared with the release branch. Refer this document to identify the cyclic dependencies introduced by this PR. |
…encies - Move types to dedicated type files - Update imports to reference new type locations - Reduce cyclic dependencies to address memory issues Testing: No functional changes Co-Authored-By: arpit@appsmith.com <arpit@appsmith.com>
40cc01e
to
1eed8e2
Compare
This PR has increased the number of cyclic dependencies by 31, when compared with the release branch. Refer this document to identify the cyclic dependencies introduced by this PR. |
Description
Separates type definitions from implementation files to reduce cyclic dependencies and address memory allocation issues. This change:
Files affected:
Type of change
How Has This Been Tested?
Link to Devin run: https://app.devin.ai/sessions/490714490db545b59fbe09e1c34c1cb3