Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple New Properties #19

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Couple New Properties #19

wants to merge 33 commits into from

Conversation

oxters168
Copy link

Hey, I really like the work you did here, thanks for sharing it. I needed some extra parameters for my project so I thought I'd share what I've added.

  • I added the ability to set the fragment/vertex shaders directly using strings
  • I added a way to set the frame rate of the shader when set to continuous to improve performance

If you want me to make any modifications, let me know.

oxters168 added 30 commits May 1, 2022 23:07
@oxters168
Added the ability to directly set the fragment and vertex shaders as …
8632ac7 
…strings
@oxters168
Added fps as ShaderView property.
d95a978 
Updated readme.
@oxters168
Changed fps to be used in the await call of the drawing thread rather…
9e58f5c 
… than the function that checks if ready to draw shader.
@oxters168
Fixed an issue where await was being given 0 rather than expected amo…
fd9e88f 
…unt.

Made an fps of 0 or lower a special case.
Updated readme.
@oxters168
Moved thread await to try and fix the continuous stuck issue
48d8d47
@oxters168
Trying a different approach where the draw call is limited directly
e0c7697
@oxters168
Localized fps limiter even further
db33fd1
@oxters168
Moved back to await method but set it to right before drawing happens
3204c02
@oxters168
Removed semicolon and encapsulated line
4a477e2
@oxters168
Quick sanity check
9dcf582
@oxters168
Fixed a stupid mistake where setting fps would set render mode instead
8adc714
@oxters168
Reverted to original method
72c55d0
@oxters168
Added debug message to check under the hood
6c9084f
@oxters168
Switched to previously tried approach
b6a9e56
@oxters168
Changed start value of prevDrawTime
cbec733
@oxters168
Changed scope of mPrevDrawTime.
d526f3c 
Removed debug message.
@oxters168
Attempt at making timestep more accurate
779e0c3
@oxters168
More localized again
eb78cfc
@oxters168
Unlocalized fps.
12c5044 
Added more debug messages.
@oxters168
Opted for microseconds for more accuracy.
c61db6f 
Added and removed some debug messages.
@oxters168
Removed some debug messages.
131bdf9 
Localized again.
@oxters168
Added more debug messages
259db6b
@oxters168
Unlocalized again but included more into the if statement.
d530a0e 
Removed a debug message.
@oxters168
Removed debug messages.
404b4bf 
Changed fps to framerate in ShaderView.
Updated readme.
@oxters168
Merge branch 'FPS' into main
8b3ad45
@oxters168
Added a comment to framerate in ShaderView.
1f985cb 
Made a small change to the readme.
@oxters168
Merge branch 'FPS' into main
d8e8ad6
@oxters168
Trying await method again.
828e11f 
Made tiny change to readme.
@oxters168
Changed await to sleep.
069cb25
@oxters168
Added special case fps.
5ee858e 
Made small change in readme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@oxters168