Merge pull request #20 from appuio/feat/sales_order_rename

Rename label `sales_order_id` to `sales_order` for consistency and clarity
appuio · Dec 21, 2023 · f8eef2d · f8eef2d
2 parents 098d8bc + 212f243
commit f8eef2d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/report/report.go b/pkg/report/report.go
@@ -32,7 +32,7 @@ type ReportArgs struct {
 	OverrideSalesOrderID        string
 }
 
-const SalesOrderIDLabel = "sales_order_id"
+const SalesOrderLabel = "sales_order"
 
 // RunRange executes prometheus queries like Run() until the `until` timestamp is reached or an error occurred.
 // Returns the number of reports run and a possible error.
@@ -110,7 +110,7 @@ func processSample(ctx context.Context, odooClient OdooClient, args ReportArgs,
 	if args.OverrideSalesOrderID != "" {
 		salesOrderID = args.OverrideSalesOrderID
 	} else {
-		sid, err := getMetricLabel(s.Metric, SalesOrderIDLabel)
+		sid, err := getMetricLabel(s.Metric, SalesOrderLabel)
 		if err != nil {
 			return nil, err
 		}

diff --git a/pkg/report/report_test.go b/pkg/report/report_test.go
@@ -36,7 +36,7 @@ const promTestquery = `
 			),
 			"tenant", "my-tenant", "", ""
 		),
-	"sales_order_id", "SO00000", "", ""
+	"sales_order", "SO00000", "", ""
 	)
 `
 const promInvalidTestquery = `