Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure nil slices are sent as empty JSON arrays #18

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Ensure nil slices are sent as empty JSON arrays #18

merged 2 commits into from
Dec 7, 2023

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Dec 7, 2023

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@bastjan
Ensure client always sends empty array instead of JSON null
e5b59e3
@bastjan
Initialize record array with assumed length
60e63cb 
More or less cosmetic change with slight performance improvements possible.
@bastjan bastjan added the bug Something isn't working label Dec 7, 2023
@bastjan bastjan requested a review from a team as a code owner December 7, 2023 10:23
@bastjan bastjan changed the title Ensure nil arrays are sent as empty arrays Ensure nil slices are sent as empty JSON arrays Dec 7, 2023
DebakelOrakel
DebakelOrakel approved these changes Dec 7, 2023
View reviewed changes
Copy link

@DebakelOrakel DebakelOrakel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@bastjan bastjan merged commit 098d8bc into master Dec 7, 2023
3 checks passed
@bastjan bastjan deleted the fix-sending-json-null-to-odoo branch December 7, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DebakelOrakel DebakelOrakel DebakelOrakel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastjan @DebakelOrakel