Use syn-teams.libsonnet for alert routing discovery and alert patching
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because the projectsyn/jsonnet-libs version of `teamForApplication()` expects that the `applications` list contains all instances present on the cluster. Without adding `openshift4-monitoring` the alert patching doesn't do the right thing anymore. We add the application in a separate commit so we can properly verify that the switch to `projectsyn/jsonnet-libs/syn-teams.libsonnet` doesn't introduce any changes.
simu
changed the title
syn-teams.libsonnet for alert routing discovery and alert patching
haasad
reviewed
Dec 19, 2024
haasad
approved these changes
Dec 20, 2024
We switch the alertrouting discovery and alert patching to use the new `syn-teams.libsonnet` Jsonnet library. This library is hosted at https://github.com/projectsyn/jsonnet-libs and is intended to be used by all components which interact with `parameters.syn.owner` and `parameters.syn.teams`.
simu
force-pushed
the
feat/use-projectsyn-jsonnet-libs
branch
from
2993010 to
12a24e3
Compare
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the alert routing discovery and alert patching to use the new
syn-teams.libsonnetJsonnet library. This library is hosted at https://github.com/projectsyn/jsonnet-libs and is intended to be used by all components which interact withparameters.syn.ownerandparameters.syn.teams.TODO
version: 'main'once Initial implementation ofsyn-teams.libsonnetprojectsyn/jsonnet-libs#1 is mergedChecklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.