Merge pull request #74 from appuio/fix/max-pods-warning

Fix warning for `kubeletConfig.maxPods > 110`
appuio · Apr 16, 2024 · 821ef02 · 821ef02
2 parents ab91779 + c6149ef
commit 821ef02
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/component/kubelet.jsonnet b/component/kubelet.jsonnet
@@ -14,7 +14,7 @@ local checkMaxPods(config) =
     && config.kubeletConfig.maxPods > 110
   then
     config {
-      kubeletConfig: {
+      kubeletConfig+: {
         maxPods: std.trace(
           '[WARNING] Upstream Kubernetes recommends to have maximum pods per node <= 110.',
           config.kubeletConfig.maxPods

diff --git a/tests/golden/maxpods/openshift4-nodes/openshift4-nodes/10_kubeletconfigs.yaml b/tests/golden/maxpods/openshift4-nodes/openshift4-nodes/10_kubeletconfigs.yaml
@@ -11,6 +11,8 @@ metadata:
 spec:
   kubeletConfig:
     maxPods: 999
+    systemReserved:
+      memory: 2Gi
   machineConfigPoolSelector:
     matchExpressions:
       - key: pools.operator.machineconfiguration.openshift.io/worker

diff --git a/tests/maxpods.yml b/tests/maxpods.yml
@@ -5,3 +5,5 @@ parameters:
       workers:
         kubeletConfig:
           maxPods: 999
+          systemReserved:
+            memory: 2Gi